Skip to content

Fix opening brace placement #15949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 19, 2021
Merged

Fix opening brace placement #15949

merged 1 commit into from
Oct 19, 2021

Conversation

laurixyz
Copy link
Contributor

@laurixyz laurixyz commented Oct 19, 2021 •
edited
Loading

The opening brace should go on the same line like it is for another function (is_leap_year) on the same page.

@javiereguiluz javiereguiluz added this to the 4.4 milestone Oct 19, 2021
@laurixyz @javiereguiluz
Fix opening brace style
22e8df0 
The opening brace should go on the same line like it is for another function (is_leap_year) in the same page.
@javiereguiluz javiereguiluz changed the base branch from 5.3 to 4.4 October 19, 2021 14:39
@javiereguiluz javiereguiluz requested a review from xabbuh as a code owner October 19, 2021 14:39
@javiereguiluz javiereguiluz merged commit e678139 into symfony:4.4 Oct 19, 2021
@javiereguiluz
Copy link
Member

Lauri, thanks and congrats on your first Symfony Docs contribution 🎉

Please note that the Symfony code style (https://symfony.com/doc/current/contributing/code/standards.html) requires a new line before the opening {, so we changed this pull request to actually fix the issue in is_leap_year() function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xabbuh xabbuh Awaiting requested review from xabbuh

Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
3 participants
@laurixyz @javiereguiluz @carsonbot